)]}' { "commit": "0bfefb8c0a468b68a81ee5301f5d14004de66d3f", "tree": "b91600eb39e72bed5c0e52860e18dc032674605f", "parents": [ "4ac09b7fc3abe50520e0fb7b3bd8c67056d047b9" ], "author": { "name": "Eugene But", "email": "eugenebut@chromium.org", "time": "Sun Feb 03 05:04:24 2019" }, "committer": { "name": "Eugene But", "email": "eugenebut@chromium.org", "time": "Sun Feb 03 05:04:24 2019" }, "message": "Reland: Do not call \u0027navigation committed\u0027 callback if there was no pending item to commit.\n\nGetPendingItem can return null inside webView:didCommitNavigation:\nThis is due to crbug.com/925304, which allows to discard pending items\nby another navigations prematurely.\n\nIf pending item is null, it means that Navigation Manager will not commit\nthat item and WebStateObservers can crash because they expect to have at\nleast one committed item.\n\nThis CL leaves navigation as \"uncommitted\" if there was no pending item\ninside webView:didCommitNavigation:\n\nOriginal CL: https://chromium-review.googlesource.com/c/1448683\n\nTBR\u003deugenebut@google.com\n\n(cherry picked from commit 621ddc377ebc96f7ecd524a39956b911fd70d6f1)\n\nBug: 925304\nChange-Id: I7852da807d183e87d1fd029d75ed63cde2287d7b\nReviewed-on: https://chromium-review.googlesource.com/c/1450300\nCommit-Queue: Eugene But \u003ceugenebut@chromium.org\u003e\nReviewed-by: Justin Cohen \u003cjustincohen@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#628537}\nReviewed-on: https://chromium-review.googlesource.com/c/1451219\nReviewed-by: Eugene But \u003ceugenebut@chromium.org\u003e\nCr-Commit-Position: refs/branch-heads/3683@{#148}\nCr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}", "tree_diff": [ { "type": "modify", "old_id": "7a816e53adcc47f36eac1df7203de702ce50cf6d", "old_mode": 33188, "old_path": "ios/web/web_state/ui/crw_web_controller.mm", "new_id": "490456f02c6b6d7f89cff8aede87c67b00984333", "new_mode": 33188, "new_path": "ios/web/web_state/ui/crw_web_controller.mm" } ] }