Google Git
Sign in
chromium / chromium / src / 0cba4e84f9d136175c5a54dd816465c0b248e487
commit0cba4e84f9d136175c5a54dd816465c0b248e487[log] [tgz]
authorXiaocheng Hu <xiaochengh@chromium.org>Tue May 22 06:28:52 2018
committerCommit Bot <commit-bot@chromium.org>Tue May 22 06:28:52 2018
tree59f7fae4cb876d10b6ff15e05675ea0945986ee1
parent6469cdf24e1442ef6a5ee0b66bac004166830cc8 [diff]
Refactor FindForwardBoxInPossiblyBidiContext for SelectionModifierCharacter

The above mentioned function currently mutates its local variables
arbitrarily, making the code hard to read.

This patch changes all local variables to constants to improve readability.

Change-Id: Ica7c155633cf3091ad4ed53f98baca5842f93ea6
Reviewed-on: https://chromium-review.googlesource.com/1068150
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560498}
1 file changed
tree: 59f7fae4cb876d10b6ff15e05675ea0945986ee1
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .