commit | 1289dbf1d9ef93c745f2c33ce701b5905d8d4928 | [log] [tgz] |
---|---|---|
author | Tommy C. Li <tommycli@chromium.org> | Thu May 23 16:34:13 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Thu May 23 16:34:13 2019 |
tree | a208b479bf530a499a34cdc7ca0bf09ec7c7c156 | |
parent | 97304e713314e8e90ebe2a55a0709265795bd861 [diff] |
[omnibox] Move page classification logic to LocationBarModel This moves OmniboxEditModel::ClassifyPage to LocationBarModel to make it accessible to the Android codebase. This CL also fixes the Query in Omnibox behavior. This logic is duplicated in AutocompleteControllerAndroid, which does not handle the Query in Omnibox case. In a followup CL, we will redirect the Android code to use the shared implementation within LocationBarModel. Mechanically speaking, this moves ClassifyPage from OmniboxEditModel to LocationBarModel. It also moves three supporting methods from OmniboxClient to LocationBarModelDelegate. This will enable Android to use that code, since Android has no concept of either OmniboxEditModel or OmniboxClient, but does use LocationBarModel extensively. Bug: 963680, 912722 Change-Id: I1f607ff720282a8e405caaf86bf3e11e5ec43e06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622637 Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#662673}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .