tree a208b479bf530a499a34cdc7ca0bf09ec7c7c156
parent 97304e713314e8e90ebe2a55a0709265795bd861
author Tommy C. Li <tommycli@chromium.org> 1558629253 +0000
committer Commit Bot <commit-bot@chromium.org> 1558629253 +0000

[omnibox] Move page classification logic to LocationBarModel

This moves OmniboxEditModel::ClassifyPage to LocationBarModel to make
it accessible to the Android codebase.

This CL also fixes the Query in Omnibox behavior.

This logic is duplicated in AutocompleteControllerAndroid, which does
not handle the Query in Omnibox case. In a followup CL, we will
redirect the Android code to use the shared implementation within
LocationBarModel.

Mechanically speaking, this moves ClassifyPage from OmniboxEditModel to
LocationBarModel. It also moves three supporting methods from
OmniboxClient to LocationBarModelDelegate.

This will enable Android to use that code, since Android has no
concept of either OmniboxEditModel or OmniboxClient, but does use
LocationBarModel extensively.

Bug: 963680, 912722
Change-Id: I1f607ff720282a8e405caaf86bf3e11e5ec43e06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622637
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662673}