Google Git
Sign in
chromium / chromium / src / 52b228c7b16e8d1648f6b750ad404b2d7b3e9b1e
commit52b228c7b16e8d1648f6b750ad404b2d7b3e9b1e[log] [tgz]
authorJinsong Fan <fanjinsong@sogou-inc.com>Wed Feb 13 20:19:55 2019
committerCommit Bot <commit-bot@chromium.org>Wed Feb 13 20:19:55 2019
tree226462e5e824b826c4aeec39a03bf75cc53d85c7
parent8ea62c2ca477e3b75e7633549d0a60e4f973f6ca [diff]
Fix Selection Popup flash before disappear

If the Selection Popup shows on the contenteditable, when user clicks outside
the contenteditable box, the selected text is cleared in onSelectionChanged(),
and onNodeAttributeUpdated() will be called, so ActionMode will invalidate and
update with the new menus before SELECTION_HANDLES_CLEARED happens. This causes
the Selection Popup to flash before disappear. The CL fixes it.

Bug: 924039
Change-Id: I85e35ecc9ab1f51e5117131eab05ff0ee97c1402
Reviewed-on: https://chromium-review.googlesource.com/c/1426252
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631873}
3 files changed
tree: 226462e5e824b826c4aeec39a03bf75cc53d85c7
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .