commit 142e5a367007576535ba397dfe3f596f26eef193
author Marc Treib <treib@chromium.org> Wed Mar 13 10:17:49 2019
committer Commit Bot <commit-bot@chromium.org> Wed Mar 13 10:17:49 2019
tree 168c55ce2b8a2a9656c6e4b8918fd9772fc30f86
parent 4a064a92747bd0515d55308b48182842faa506d1

sync_ui_util::ShouldRequestSyncConfirmation: don't check IsSyncRequested

Before this CL, ShouldRequestSyncConfirmation() checked (among other
things) "IsAuthenticatedAccountPrimary() && IsSyncRequested()".
However, after a "Reset Sync" operation from the dashboard,
IsSyncRequested() is set to false, which means
ShouldRequestSyncConfirmation() is false, which means
GetMessagesForAvatarSyncError() returns NO_SYNC_ERROR, which means no
error shows up in the avatar menu - it still claims "Syncing to
<account>", which is clearly wrong.

To fix this, this CL simply drops the IsSyncRequested() check from
ShouldRequestSyncConfirmation(). This is safe, because a dashboard reset
is the only situation that can get the user into a primary-account-but-
Sync-not-requested state (and even if there were another way to get
into that state, we'd want to treat it as an error too).

Note that this is only relevant for managed (i.e. enterprise) accounts,
since all other accounts get signed out when Sync is reset from the
dashboard.

Bug: 936882
Change-Id: I4d40efaf8fc145e4db6b30bb4c44f0245f6f387b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517911
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#640274}