commit | 15240176470e8e27cbb130a064415fb5401a2cc2 | [log] [tgz] |
---|---|---|
author | Ryan Sturm <ryansturm@chromium.org> | Mon Jan 21 18:55:13 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Jan 21 18:55:13 2019 |
tree | 2a7518880e2403ca76929135290d9115c94fdf2f | |
parent | de610823c81c9740c5e5174dc748389caeb37f35 [diff] |
Updating PreviewsState for IO thread redirects This change does not currently affect any Previews (DRP and Offline do not update state during a redirect); however, HTTPS server previews will move from a UI thread triggering mechanism to a UI thread mechanism. To support this behavior, the ResourceRequest is updated during a redirect. This is still not enough to support DRP, but Offline and HTTPS server lite pages (URLLoaderRequestInterceptors) will see the updated changes. DRP may see the changes in the case that the network service URLLoader is restarted, but that behavior is not consistent, and for that reason, it is not supported. DRP uses a URLLoader request throttle, so it can only update the request sufficiently at the start of the URLLoader. I will add a browser test later for lite page previews around this behavior once the URLLoader implementation is further along, currently I have manually tested; it behaves as expected. Bug: 921792 Change-Id: I9fb2ad1efbc5af9555a640e9ce55844b799d39a5 Reviewed-on: https://chromium-review.googlesource.com/c/1413337 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Camille Lamy <clamy@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#624639}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .