commit | 156cecbc57b0cf55db5aa8d521292f3aaa7bd5ff | [log] [tgz] |
---|---|---|
author | Jeevan Shikaram <jshikaram@chromium.org> | Wed May 22 04:16:07 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed May 22 04:16:07 2019 |
tree | 5da6f05aad340f0ddd0b66c8e0ed9d2037463fca | |
parent | d0bd51908bf0a4e0c12f706ff243b53f67c1e265 [diff] |
[App Service] Get file path in a background thread. ExtensionResource::GetFilePath will DCHECK if it's not called on a background thread. Currently, the App Service calls this method on the UI thread, which causes App Management to crash when DCHECKs are enabled. This CL refactors apps::LoadIconFromExtension to ensure that this method is only called on a background thread. Bug: 916380 Change-Id: I3ba8757e884c6336b4b7b61fc46363c8273fcc86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619586 Reviewed-by: Nigel Tao <nigeltao@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#662061}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .