)]}' { "commit": "15e125a9c3397ac04cfef175131cfcb35330fc72", "tree": "1c11168808ffa6a97a7ab2796ba4bc80417d393b", "parents": [ "921ef39253da73b1fe72f886f3bff917cb01a37a" ], "author": { "name": "Frédéric Wang", "email": "fwang@igalia.com", "time": "Thu Feb 27 09:29:21 2020" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Feb 27 09:29:21 2020" }, "message": "[mathml] Add unit tests for OpenTypeMathSupport\n\nA platform API for the OpenType MATH table has been added in [1] but\nthe code is not verified by blink_platform_unittests. This CL adds a\nfew tests for fonts with or without a MATH table as well as constants\nrelated to script scale down, fractions and radicals. This is not\nexhaustive but at least cover all the return statements of\nOpenTypeMathSupport::HasMathData and OpenTypeMathSupport::MathConstant.\n\nThis also modifies the result of OpenTypeMathSupport::MathConstant\nfor fonts without a MATH table: Instead of returning HarfBuzz\u0027s zero\nvalue, the function returns a null optional so that callers can decide\nthe default value to use.\n\n[1] https://chromium-review.googlesource.com/c/chromium/src/+/2041485\n\nBug: 6606, 1050596\nChange-Id: I4e7f329bbabb1759f6a1adeaa74b49912812ba8e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073721\nCommit-Queue: Frédéric Wang \u003cfwang@igalia.com\u003e\nReviewed-by: Dominik Röttsches \u003cdrott@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#744982}\n", "tree_diff": [ { "type": "modify", "old_id": "f65dbbcbcc18889df5611e601e075afd42540606", "old_mode": 33188, "old_path": "third_party/blink/renderer/platform/BUILD.gn", "new_id": "391384176f68757c65f912505f59ff09a1be2320", "new_mode": 33188, "new_path": "third_party/blink/renderer/platform/BUILD.gn" }, { "type": "modify", "old_id": "6debef8932a6dabd0e395a1b4bce94198e3db8be", "old_mode": 33188, "old_path": "third_party/blink/renderer/platform/fonts/opentype/open_type_math_support.cc", "new_id": "e90a002b99d2b394183ccbbea7bdd2fe9300c8c6", "new_mode": 33188, "new_path": "third_party/blink/renderer/platform/fonts/opentype/open_type_math_support.cc" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "bdc468cf9dca5ee2e1cc538a7a07a5ba03ceb1f7", "new_mode": 33188, "new_path": "third_party/blink/renderer/platform/fonts/opentype/open_type_math_support_test.cc" }, { "type": "modify", "old_id": "adb0162bb56a8025682900d48ea46b09f40fe899", "old_mode": 33188, "old_path": "third_party/blink/renderer/platform/testing/unit_test_helpers.cc", "new_id": "1215543c54bce56ea02ca47826d0ad95a3a2336d", "new_mode": 33188, "new_path": "third_party/blink/renderer/platform/testing/unit_test_helpers.cc" }, { "type": "modify", "old_id": "87d71599901f24e7e095e236cbf8c87f6a117047", "old_mode": 33188, "old_path": "third_party/blink/renderer/platform/testing/unit_test_helpers.h", "new_id": "a964623e4780d1a1d902cb0328edfd4752f8dabc", "new_mode": 33188, "new_path": "third_party/blink/renderer/platform/testing/unit_test_helpers.h" } ] }