commit | 1725b48b6a5c24d7b6978d4ca895bf9de6fec518 | [log] [tgz] |
---|---|---|
author | Tom Tan <Tom.Tan@microsoft.com> | Fri Mar 08 19:16:04 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Mar 08 19:16:04 2019 |
tree | 89ff560cb74cd979047868583f7070cbcb6243a9 | |
parent | dee5d4844bd6b489d1d22d5b6a4c0fbd5e003db4 [diff] |
Fix calling alternate_version_generator.exe for Windows ARM64 cross build Create symlink for alternate_version_generator.exe on Windows has DLL load issue for component build because the folder where the executable resides is not in the executable search path. The change goes to the hard way and fixes the caller side to pass in correct path for the tool with its input/output paths adjusted. This was suggested by Nico Weber in the comments for crrev.com/c/1474438. I tested the change locally for ARM64 Win32 components build where it was broken, I also verified Windows x64 debug and no regression found. Bug: 927113 Change-Id: Ie0e1c9bd0553a9b2ec1c3c125d7ca8d3d7e8401c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502532 Commit-Queue: Tom Tan <Tom.Tan@microsoft.com> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#639109}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .