Google Git
Sign in
chromium / chromium / src / 1726e18dded5365a3c978adad98aabaf414283d4
commit1726e18dded5365a3c978adad98aabaf414283d4[log] [tgz]
authorKen Rockot <rockot@chromium.org>Thu Feb 28 09:48:56 2019
committerCommit Bot <commit-bot@chromium.org>Thu Feb 28 09:48:56 2019
treeb701e86c6d1fc4e198147e2981168d748aba798d
parent5db8d9c98aafc23feffe973368db1327a7cddc00 [diff]
NS: Support WebRequest with download link requests

Downloads initiated by download link interaction were not plumbed
through the WebRequest path at all when NS is enabled. This fixes
that. See changes to download_manager_impl.cc, which constitute the
bulk of the interesting diff here.

The rest of the CL is plumbing a flag through
WebRequestProxyingURLLoaderFactory so it knows that these requests
are downloads, because leaning on ResourceType seemed like the
wrong thing to do (it's defined by content, and the ResourceRequest
is constructed within a component that can't depend on content).

Bug: 935567
Change-Id: I88f535d5e99435d7bae8ca6046ffa1b88d339bf1
Reviewed-on: https://chromium-review.googlesource.com/c/1493637
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636386}
22 files changed
tree: b701e86c6d1fc4e198147e2981168d748aba798d
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .