Google Git
Sign in
chromium / chromium / src / 17c608f8c2aed5a20a7f9e1a1ed5002b48175502
commit17c608f8c2aed5a20a7f9e1a1ed5002b48175502[log] [tgz]
authorYi Su <mrsuyi@chromium.org>Fri Nov 30 19:04:31 2018
committerCommit Bot <commit-bot@chromium.org>Fri Nov 30 19:04:31 2018
treef4ebc9563952663979b6722764acc982b252805f
parentdefc3a17c32c005efef570c6ba779eb05aa300e2 [diff]
Fix password settings crash by modifying property attributes of
TableViewTextItem.textColor.

The Canary crashes when a TableViewTextItem configures its cell and
checks its "textColor" property, which is "assign" and might get released
after assigned. This CL fixes it by changing the property's "assign"
attribute to "strong" so that the UIColor object will be retained.

Bug: 910542
Change-Id: I44b6a60c52c5a470e69a44ca6670720446ef084b
Reviewed-on: https://chromium-review.googlesource.com/c/1356585
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612716}
1 file changed
tree: f4ebc9563952663979b6722764acc982b252805f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .