commit | 185d35edd7dd413a482d7bb2b65b42e55e00c608 | [log] [tgz] |
---|---|---|
author | henrika <henrika@chromium.org> | Thu Apr 25 13:22:43 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Apr 25 13:22:43 2019 |
tree | 4f07373862a47eb27771b60b362df5ec25c6a824 | |
parent | cb9dae5d0ff597027948ecc85eec11018803a8bb [diff] |
Fixes CoreAudioUtil::CreateDevice for loopback mode. Takes loopback devices into account in CoreAudioUtil::CreateDevice() which previously failed with E_INVALIDARG when a loopback device was selected. This change might also have positive side effects for loopack mode when used in combination with multi-channel input devices since the input channel format will now be correct. Also fixes the presubmit error below: ** Presubmit ERRORS ** Banned functions were used. media\audio\win\core_audio_util_win.cc:461: Improper use of Microsoft::WRL::ComPtr<T>::GetAddressOf() has been implicated in a few leaks. Use operator& instead. BUG=938938 TEST=WinAudioInputTest.WASAPIAudioInputStreamLoopback Change-Id: I4e2f0add6dc743dd0d10a476ff67f46e66a3dec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578746 Commit-Queue: Henrik Andreasson <henrika@chromium.org> Reviewed-by: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#654005}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .