commit | 1895a5701ffa2639f075a58278c7a65f4849677b | [log] [tgz] |
---|---|---|
author | Daniel Bratell <bratell@opera.com> | Mon Feb 18 18:42:09 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Feb 18 18:42:09 2019 |
tree | f11a80360114c24b114cdbea2e0f3f5685034698 | |
parent | a23f8569a5b5563676462f3f4280ff935ec06b1e [diff] |
Remove variable shadowing in blink/modules/webaudio In an effort to reduce or even ban variable shadowing, this renames a variable to avoid such shadowing. I'm interested in prohibiting shadowing because I think it might prevent potential jumbo problems. The exact error this avoids is: third_party/blink/renderer/modules/webaudio/audio_worklet_global_scope.cc:347:17: error: declaration shadows a local variable [-Werror,-Wshadow] for (uint32_t output_bus_index = 0; output_bus_index < output_buses->size(); ^ third_party/blink/renderer/modules/webaudio/audio_worklet_global_scope.cc:253:12: note: previous declaration is here uint32_t output_bus_index = 0; ^ 1 error generated. Bug: 923510 Change-Id: Ic861379f7892eb044b4ab3035bde2271521fd2c1 Reviewed-on: https://chromium-review.googlesource.com/c/1477011 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Daniel Bratell <bratell@opera.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#633129}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .