tree 86f623ad680042c476616869f01f5ffceb6be2f4
parent cd64ab02706bf380190336c08e6f6021122815d2
author Fergus Dall <sidereal@google.com> 1643094929 +0000
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1643094929 +0000

crostini_upgrader: Update to match UI feedback

Changes:

 - Change the string that tells the user about our new log file into two
   strings for failure/success

 - Stop showing the error icon when we display error logs

 - Double the default height of the log box, since we now have more
   space

 - Re-add the bottom margin to the error icon that was reduced in
   CL:2340352 and removed in CL:3312456. This was done to make more
   space for the logs, but no longer makes sense since they're now
   mutally exclusive.

 - Make the close/cancel button align right when it's the only
   button. This was failing due to improper use of the "close-button"
   class, which includes an unconditional 8 pixel margin on the
   right. Instead we should specify the gap in the container, where it
   will only be inserted *between* elements.

 - In the UPGRADE_ERROR and ERROR states put the "close" label on the
   cancel button, rather then "cancel", as we do in the
   RESTORE_SUCCEEDED and SUCCEEDED states.

 - Only show the "close" button in the RESTORE_SUCCEEDED rather then
   also showing the "done" button.

 - Show the default illustration in the BACKUP and UPGRADING states
   instead of leaving the space blank.

 - Remove the close and minimise buttons at the top of the dialogue

Bug: 1217902
Change-Id: Iec8c5b8ee7bd14719ffe655dbbc4f2573e20ae81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3372525
Reviewed-by: David Munro <davidmunro@google.com>
Commit-Queue: Fergus Dall <sidereal@google.com>
Cr-Commit-Position: refs/heads/main@{#962882}