Google Git
Sign in
chromium / chromium / src / 1a597bc4e4b20c84495bc8eaa7213b1b30c21cde
commit1a597bc4e4b20c84495bc8eaa7213b1b30c21cde[log] [tgz]
authorKaran Bhatia <karandeepb@chromium.org>Thu Feb 07 00:00:01 2019
committerCommit Bot <commit-bot@chromium.org>Thu Feb 07 00:00:01 2019
treee713153232e52e2b529819c278e84b215bc9f923
parentcd23df9d8f4df779ccd3f1caa4532fa826ad8449 [diff]
DNR: Improve install warnings.

This CL improves the install warnings for manifest rules which can't be parsed.
To do this enable error generation for the Declarative Net Request API. Another
side effect of this is that rules with unknown keys are now ignored (with an
install warning), instead of being parsed correctly.

Generate code diff- https://www.diffchecker.com/9d55eAZ5

BUG=926609

Change-Id: I695225f8dd8e96366d6462d31414402d0b14c4f4
Reviewed-on: https://chromium-review.googlesource.com/c/1454085
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629788}
5 files changed
tree: e713153232e52e2b529819c278e84b215bc9f923
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. mash/
  33. media/
  34. mojo/
  35. native_client_sdk/
  36. net/
  37. pdf/
  38. ppapi/
  39. printing/
  40. remoting/
  41. rlz/
  42. sandbox/
  43. services/
  44. skia/
  45. sql/
  46. storage/
  47. styleguide/
  48. testing/
  49. third_party/
  50. tools/
  51. ui/
  52. url/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .