commit | 1b3bc54c0f6abfcdff0292e66f0a9d31958ae46f | [log] [tgz] |
---|---|---|
author | Sandra Sun <sunyunjia@chromium.org> | Tue Jul 17 22:22:59 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Jul 17 22:22:59 2018 |
tree | 15c84278983405450413f63cb3540be4b0009d9e | |
parent | 7c8fad4aae5553262a7bb32f4c3e5a974e9f294d [diff] |
Reland "Snaps after scrollbar clicking." This reverts commit dab534357763fbe122191d6c7f749816e2c08696. Reason for revert: Couldn't reproduce the test failure on a local Win7 and the failure seems unrelated to my change. Try to submit it once more and will investigate it further if it fails again. Original change's description: > Revert "Snaps after scrollbar clicking." > > This reverts commit e98df9c6e2269035a9abb23ca8fd8dc906ad3d38. > > Reason for revert: suspect for webkit_layout_tests consistently > failing, e.g. > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%281%29/81791 > > Original change's description: > > Snaps after scrollbar clicking. > > > > After user clicking on the scrollbar's track or arrows, we should snap > > to the closest snap position of the container. This is done by simply > > moving SnapAfterScrollbarDragging() from > > ScrollableArea::MouseReleasedScrollbar() up to Scrollbar::MouseUp(). > > > > This patch also rewrites the previous > > snaps-after-scrollbar-dragging.html test using the gesture-util.js, and > > adds the new clicking tests to it as well. > > > > Bug: 860768 > > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > > Change-Id: I75267c3fc0917ecf5c14673a1eb480a047d03824 > > Reviewed-on: https://chromium-review.googlesource.com/1127153 > > Commit-Queue: Sandra Sun <sunyunjia@chromium.org> > > Reviewed-by: David Bokan <bokan@chromium.org> > > Reviewed-by: Majid Valipour <majidvp@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#575191} > > TBR=bokan@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org > > Change-Id: Iab3c3c489bda0fc6b150ba0e0a5bde8de9721798 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 860768 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Reviewed-on: https://chromium-review.googlesource.com/1138013 > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575202} TBR=bokan@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org,mastiz@chromium.org Change-Id: Iaef646348cc6e1c0a6e8b0bca3deb9296f79a7e7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 860768 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1138473 Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Reviewed-by: Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#575805}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .