commit | 1d01cbaf3860d44dc1128dc0337258f63024c4d4 | [log] [tgz] |
---|---|---|
author | Oriol Brufau <obrufau@igalia.com> | Wed Sep 02 15:43:24 2020 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Sep 02 15:43:24 2020 |
tree | 2e6cf5ba3263ef8736e60495d9d5ce8c7922186a | |
parent | 245ef327a4a4a5584717dde5ed3b5623df96fa0f [diff] |
[css-grid] Use min-content size for intrinsic maximums resolution By mistake the specification used to say that, for items spanning multiple tracks, the growth limits of the tracks with an intrinsic max track sizing function should grow to accommodate the minimum contribution of the item. But this was a mistake, because an intrinsic max track sizing function can only be min-content or max-content. So instead of distributing the minimum contribution, it should be the min-content contribution. The spec has been fixed and there is a CSSWG resolution in https://github.com/w3c/csswg-drafts/issues/4790 This patch fixes the problem by reverting r424527. The change is likely web compatible, since it only affects a rare edge case with 'minmax()' where the min sizing function is 'auto' or a fixed value smaller than the min-content contribution, the max sizing function is 'min-content', and an item whose minimum contribution is forced to be different than the min-content contribution, and spans multiple tracks. Bug: 1122084 TEST=external/wpt/css/css-grid/layout-algorithm/grid-intrinsic-track-sizes-001.html TEST=fast/css-grid-layout/grid-intrinsic-maximums.html Change-Id: I1efd6e48b55fc71f37f8303c731bfbf601ca4c70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377499 Reviewed-by: Manuel Rego <rego@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#803871}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.