Google Git
Sign in
chromium / chromium / src / 1dfdf1b070b0bdeb839714ff9ceea303606b5806
commit1dfdf1b070b0bdeb839714ff9ceea303606b5806[log] [tgz]
authorDaniel Bratell <bratell@opera.com>Fri Mar 01 14:15:10 2019
committerCommit Bot <commit-bot@chromium.org>Fri Mar 01 14:15:10 2019
treee23ffb0480a37fb6d7d96978f1918d9562438c82
parentbb4219556039f934e4f1aef8b71d2d9b9b0ec2b4 [diff]
Remove state variable shadowing in blink/paint

In an effort to reduce or even ban variable shadowing, this renames a
variable. I'm interested in prohibiting shadowing because I think it
might prevent potential jumbo problems.

The exact warning this this avoids is:

third_party/blink/renderer/core/paint/paint_property_tree_builder.cc:1762:40: error: declaration shadows a local variable [-Werror,-Wshadow]

        EffectPaintPropertyNode::State state;
                                       ^
third_party/blink/renderer/core/paint/paint_property_tree_builder.cc:1711:38: note: previous declaration is here
      ScrollPaintPropertyNode::State state;
                                     ^
third_party/blink/renderer/core/paint/paint_property_tree_builder.cc:1776:40: error: declaration shadows a local variable [-Werror,-Wshadow]
        EffectPaintPropertyNode::State state;
                                       ^
third_party/blink/renderer/core/paint/paint_property_tree_builder.cc:1711:38: note: previous declaration is here
      ScrollPaintPropertyNode::State state;
                                     ^

Bug: 923510
Change-Id: Ia64158f91a8f07cd238e01b1e1e31b35a6b5ac06
Reviewed-on: https://chromium-review.googlesource.com/c/1496874
Commit-Queue: Daniel Bratell <bratell@opera.com>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Auto-Submit: Daniel Bratell <bratell@opera.com>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#636803}
1 file changed
tree: e23ffb0480a37fb6d7d96978f1918d9562438c82
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .