commit | 1e511063dfee87d89b9b8eb4028deb81abc407a6 | [log] [tgz] |
---|---|---|
author | Christopher Grant <cjgrant@chromium.org> | Mon Jan 21 21:03:35 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Jan 21 21:03:35 2019 |
tree | b09fc6672f308757a546cce8f9aa9755259c80af | |
parent | 4dbbe3ca6db9e72afa789de86af1745a732e7dd1 [diff] |
Android: Fix secondary ABI GN inconsistencies Some GN configs use "current_toolchain == default_toolchain" to avoid work on the host toolchain. A problem with this is that not all non-default toolchains are the host toolchain. In the 64-bit ARM Android case, there's the default toolchain (arm64), and the secondary ABI toolchain (arm32). A check like the one listed above yields incorrect behavior in this case. Instead, it needs to be "is current toolchain the default toolchain (ie. arm64), or, if on Android, is the current toolchain the secondary ABI toolchain". This could be more simply stated as "are you one of the toolchains used for the destination". Hence this change introduces a variable, is_a_destination_toolchain, which tries to convey that we're on a non-host toolchain. BUG=899570 Change-Id: I534abeb91e116f30be8a1625f02af64b4acfc206 Reviewed-on: https://chromium-review.googlesource.com/c/1412298 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#624666}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .