Google Git
Sign in
chromium / chromium / src / 5e252e528c8aa7effe5791d96a21d46a517cc786
commit5e252e528c8aa7effe5791d96a21d46a517cc786[log] [tgz]
authorBenoît Lizé <lizeb@chromium.org>Tue Jun 25 12:16:33 2019
committerCommit Bot <commit-bot@chromium.org>Tue Jun 25 12:16:33 2019
treea2c9f3f98d6bb9df8f3856b59327b78fdd041ddf
parent8e2c2eacb792f7b50673aed9f8c85510fcf4c5bc [diff]
tools: Comment and correctness fixes in dump_process_memory.

It is not necessary to kill the entire process group to dump it, and it is not
required to ptrace() it. Fix the first one, and document why ptrace() may still
be useful.

Reported by bgeffon@google.com.

Bug: 845459
Change-Id: I9f08e7208cfcfdec00bcaf80f83c585f1d4ea195
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675649
Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672040}
1 file changed
tree: a2c9f3f98d6bb9df8f3856b59327b78fdd041ddf
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. .clang-format
  52. .eslintrc.js
  53. .git-blame-ignore-revs
  54. .gitattributes
  55. .gitignore
  56. .gn
  57. .vpython
  58. AUTHORS
  59. BUILD.gn
  60. CODE_OF_CONDUCT.md
  61. codereview.settings
  62. DEPS
  63. ENG_REVIEW_OWNERS
  64. LICENSE
  65. LICENSE.chromium_os
  66. OWNERS
  67. PRESUBMIT.py
  68. PRESUBMIT_test.py
  69. PRESUBMIT_test_mocks.py
  70. README.md
  71. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .