Google Git
Sign in
chromium / chromium / src / 1fb41870b9c86ed7606a95eab429c17fd2783907
commit1fb41870b9c86ed7606a95eab429c17fd2783907[log] [tgz]
authorDaniel Bratell <bratell@opera.com>Wed Apr 03 09:15:03 2019
committerCommit Bot <commit-bot@chromium.org>Wed Apr 03 09:15:03 2019
tree73af95630a56241a0db85bd45fba60398a782f52
parent844971dac5125b47407181b3bdf5eb34eab8706d [diff]
Include headers, not cc files, to fix duplicate symbols

Some builds failed with duplicate symbols because
code was compiled twice. Most builds were ok because of the
linker optimization to ignore object files that are
completely unused. In jumbo builds there were no object
files that were completely unused so the linker complained
loudly.

Also, since some code is used outside the accessibility
component, in unittests, that code needs to be exported.

TBR=almaher@microsoft.com,dmazzoni@chromium.org

Bug: 928948
Change-Id: I77aeb8beff451be16b0d5f8fe4d62e70f7c66eae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549127
Reviewed-by: Daniel Bratell <bratell@opera.com>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#647198}
2 files changed
tree: 73af95630a56241a0db85bd45fba60398a782f52
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .