commit | 20ee547ec76ad5e3f6ccbea830a3606ef3673ebb | [log] [tgz] |
---|---|---|
author | Daniel Bratell <bratell@opera.com> | Mon Apr 15 06:10:29 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Apr 15 06:10:29 2019 |
tree | 8ba867cc1a3a3672f188cdc8968a669fd0e551de | |
parent | 27853f9e30a4024b2a8e287874fb72d168ce8cf6 [diff] |
Added missing deps for screen_orientation_lock_types The mojo types using screen_orientation_lock_types.typemap were missing a build dependency which made gn check --check-generated report the error below: ERROR at //out/Default/gen/services/device/public/mojom/screen_orientation_lock_types.mojom-forward.h:37:11: Include not allowed. ^------------------------------------------------------------------------------------ It is not in any dependency of //services/device/public/mojom:mojom The include file is in the target(s): //third_party/blink/public/common:headers which should somehow be reachable. Since code in //services use this, //services/* must also be added to the list of targets that can use blinks public/common:headers target. (Or should the whitelist just be deleted since it seems to list most of Chromium). Bug: 938893 Change-Id: I5bee9574edf1ae5bb288924f52a113f855f33a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538507 Auto-Submit: Daniel Bratell <bratell@opera.com> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#650703}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .