Google Git
Sign in
chromium / chromium / src / 213446d0215138261ed8deb050528d106bfad43c
commit213446d0215138261ed8deb050528d106bfad43c[log] [tgz]
authorLowell Manners <lowell@chromium.org>Wed Jan 09 17:31:03 2019
committerCommit Bot <commit-bot@chromium.org>Wed Jan 09 17:31:03 2019
treed0021ffb699239da1b2103bd8d7f03c4f9271cc4
parentaa323fc134b020e3ddb77767e34382fe6264089e [diff]
Remove integration test dependencies on FakeGaiaCookieManagerService.

Instead of creating a FakeGaiaCookieManagerService, we now set mock
responses using the TestURLLoaderFactory that already existed in
SyncTest.

As part of this change, the helpers that need access to the
TestURLLoaderFactory in SyncTest were moved from
secondary_account_helper to a test class which inherits from SyncTest.

Removing this dependency will make it easier to eliminate FakeGCMS
entirely:
http://doc/1t0ZtuV7h-znzdItFgBW0aKPscAwWXIBuNZnNlEGgi7g#heading=h.7dt3rezdvj2u

Bug: 907782
Change-Id: Id60b56ecc76bf0d4bbe0089deec53e0d4225d4f0
Reviewed-on: https://chromium-review.googlesource.com/c/1396148
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621200}
12 files changed
tree: d0021ffb699239da1b2103bd8d7f03c4f9271cc4
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .