commit | 218f742d03951b7bc305d8e85cc7f7a9e2b6cbc7 | [log] [tgz] |
---|---|---|
author | Lei Zhang <thestig@chromium.org> | Tue Mar 05 05:18:40 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Mar 05 05:18:40 2019 |
tree | b0a11ae984e84db675a0541fa929f41b514e84fa | |
parent | 4203814edf320df6889ded32558b5b3467c146f2 [diff] |
Fix keyboard focus on webpages after finishing window.print(). As is, by the time PrintViewManager::PrintPreviewDone() gets called to unblock a Print Preview initiator, FocusController already tried to give the initiator focus and failed, because the initiator was in a blocked state. Add PrintViewManager::PrintPreviewAlmostDone() and call it right before the Print Preview dialog closes. This is necessary to get the timing right so the underlying Print Preview initiator can be unblocked before the FocusController tries to give it back focus. BUG=936542 TEST=Manual, see bug. Change-Id: Ifa7fcb451b94a6da82c554b685bca350be032120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497860 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#637595}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .