commit 22b4e8b323bd9ff27f97603045f52886a10935a6
author danakj <danakj@chromium.org> Thu Aug 01 23:14:39 2019
committer Commit Bot <commit-bot@chromium.org> Thu Aug 01 23:14:39 2019
tree 7c86c6e1d8c13668df19bf2d221b2c56cc52260f
parent d22ae8d8edca1318b63f5002df6a85a8fb19834a

Always start RenderFrames and their RenderWidgets as hidden.

We start them as shown if the WebContents is shown, then immediately
send a Hide() unconditionally - in different places for child and main
frames. Instead just always start them hidden and remove all the
plumbing.

This is toward https://chromium-review.googlesource.com/c/chromium/src/+/1693812
wherein I'd like to DCHECK we don't call OnHidden IPC for a provisional
RenderWidget, which we currently do. Right now we DCHECK that we don't
call it for a frozen widget, which includes provisional main frame
widgets, but not the first one. And it's the first one we create shown
and then hide.

Renderer-created widgets (eg window.open()) go through
WebContentsImpl::CreateNewWidget() and should Show() immediately if the
renderer has initialized the page as shown, since there may be no navigation
afterward to show the widget in that case.

R=avi@chromium.org

Bug: 419087, 745091
Change-Id: Id7cc1981ae9fbf6a71c51a4b54fc488ba47f1753
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717702
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683381}