commit | 245ef327a4a4a5584717dde5ed3b5623df96fa0f | [log] [tgz] |
---|---|---|
author | Morten Stenshorne <mstensho@chromium.org> | Wed Sep 02 15:43:12 2020 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Sep 02 15:43:12 2020 |
tree | 25bbd6a0906a99d4474598cbe5810823012b8faf | |
parent | cf97f3f89a5ac7d087004a1dc2d72d375315b040 [diff] |
[LayoutNG] Handle auto column-count correctly. Column balancing failed when column-count was auto (and column-width was non-auto). The ResolveUsedColumnCount() function that takes a ComputedStyle parameter forgot to set column_count to 0 if computed column-count was auto. The other ResolveUsedColumnCount() function expects this, or it will pretend that column-count is 1 (since that would be what's passed). ResolveUsedColumnInlineSize() has this right, and we also have unit tests that pass 0 when column-count is supposed to be auto. Fixes 20 tests. Bug: 829028 Change-Id: I47f790ca6aa8566d74b99bdaa16f857d29c2084b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388282 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#803870}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.