Google Git
Sign in
chromium / chromium / src / 245ef327a4a4a5584717dde5ed3b5623df96fa0f
commit245ef327a4a4a5584717dde5ed3b5623df96fa0f[log] [tgz]
authorMorten Stenshorne <mstensho@chromium.org>Wed Sep 02 15:43:12 2020
committerCommit Bot <commit-bot@chromium.org>Wed Sep 02 15:43:12 2020
tree25bbd6a0906a99d4474598cbe5810823012b8faf
parentcf97f3f89a5ac7d087004a1dc2d72d375315b040 [diff]
[LayoutNG] Handle auto column-count correctly.

Column balancing failed when column-count was auto (and column-width was
non-auto).

The ResolveUsedColumnCount() function that takes a ComputedStyle
parameter forgot to set column_count to 0 if computed column-count was
auto. The other ResolveUsedColumnCount() function expects this, or it
will pretend that column-count is 1 (since that would be what's passed).
ResolveUsedColumnInlineSize() has this right, and we also have unit
tests that pass 0 when column-count is supposed to be auto.

Fixes 20 tests.

Bug: 829028
Change-Id: I47f790ca6aa8566d74b99bdaa16f857d29c2084b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388282
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803870}
3 files changed
tree: 25bbd6a0906a99d4474598cbe5810823012b8faf
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.