Google Git
Sign in
chromium / chromium / src / 2491dd10914e961e9b5a8a186b05cd7b22f85702
commit2491dd10914e961e9b5a8a186b05cd7b22f85702[log] [tgz]
authorManu Cornet <manucornet@chromium.org>Thu Jan 24 05:39:43 2019
committerCommit Bot <commit-bot@chromium.org>Thu Jan 24 05:39:43 2019
treea452635ff575a2e31a145f76e8fa49a978c2bc5e
parent55f5c137b3c6fe9316be38dc8349a97f23e2d56d [diff]
CrOS Shelf: Let the tooltip manager handle key events

This fixes a bug where a bubble (namely a hover preview bubble)
could be dismissed with a keystroke without giving the tooltip
manager a chance to do the necessary cleanup.

We'll likely need to expand this in the future to handle keyboard
navigation within the hover preview bubbles, but for now closing any
shown bubble with any key event avoids a nasty crash.

Bug: 902539
Change-Id: Ib642496f2ca1657189d0b3b9471ce2619c218b40
Reviewed-on: https://chromium-review.googlesource.com/c/1420817
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Auto-Submit: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625520}
3 files changed
tree: a452635ff575a2e31a145f76e8fa49a978c2bc5e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .