commit | 2667c345f7680a2efa4aa3574e10cc0c8a6823e6 | [log] [tgz] |
---|---|---|
author | Maksim Sisov <msisov@igalia.com> | Wed Jan 08 07:46:56 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Jan 08 07:46:56 2025 |
tree | faa12e0c98fbeca27c392288043cc62e357e6135 | |
parent | 81aaa9bd86928472ff3635ac2ff80595aa218ecb [diff] |
Check for unit to activate before notifying about success Portal's globalShortcuts interface relies on the unit name to properly assign a client for the bound commands. However, in some scenarious, there is a race between the service to be created, changed its name and activated. As a result, shortcuts might be bound before the name is changed. As a result, shortcuts might not correctly work and the client will not receive any signals. This is mostly not an issue for Chromium as it creates the global shortcuts portal linux object way earlier than it gets commands from the command service. But downstream project, which try to bind shortcuts at the same time as that instance is created, may experience this issue. As a result, they might not have shortcuts working correctly after system reboot or app restart as there is a race between those operations. Bug: None Change-Id: I8346d65e051d9587850c76ca0b8807669c161667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6110782 Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/main@{#1403434}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.