Google Git
Sign in
chromium / chromium / src / 28c1fd00c31d1a9f39eb747c728310914031291f
commit28c1fd00c31d1a9f39eb747c728310914031291f[log] [tgz]
authorWenzhao Zang <wzang@chromium.org>Mon Jan 14 20:52:20 2019
committerCommit Bot <commit-bot@chromium.org>Mon Jan 14 20:52:20 2019
tree93c80b92af9681868bdc6fbbb60a7dec79eaa75c
parentfccd9c66115a1e55a3c45d081dcb3712f0c70a15 [diff]
cros: CancelPreviewWallpaper should return early if not in preview mode

Without the early return, observers are notified of
OnWallpaperPreviewEnded even if it's not in preview mode. This may
cause potential bugs if the observer doesn't have a guard itself.

In addition, slightly adjust the logic in wallpaper picker.

Bug: None
Change-Id: I17f01bd800ec55d969d927b8ede5a06c8ee61676
Reviewed-on: https://chromium-review.googlesource.com/c/1386148
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622595}
2 files changed
tree: 93c80b92af9681868bdc6fbbb60a7dec79eaa75c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .