)]}' { "commit": "28d886c967e016a5d5812be43cd5916f577c2e10", "tree": "4510350de11125ab89cfcf60ae8a624a8659037b", "parents": [ "042e7e077ee2cb726804c27313093241b97bf09e" ], "author": { "name": "sergeyu", "email": "sergeyu@chromium.org", "time": "Thu Sep 11 21:45:02 2014" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Thu Sep 11 22:01:29 2014" }, "message": "Move PseudoTCP and channel auth out of LibjingleTransportFactory.\n\nPreviously TransportFactory interface was responsible for creation\nand initialization of several protocol layers, including PseudoTCP and\nauthentication (TLS). Simplified it so now it only creates raw datagram\ntransport channel. PseudoTcpChannelFactory is now responsible for\nsetting up PseudoTcpAdapter and AuthenticatingChannelFactory takes care\nof channel authentication. Also added DatagramChannelFactory for\nDatagram channels.\n\nThis change will make it possible to replace PseudoTcpChannelFactory\nwith an object that creates SCTP-based channels.\n\nAlso fixed a bug in SslHmacChannelAuthenticator. It wasn\u0027t working\nproperly when deleted from the callback. (base::Callback objects\nshouldn\u0027t be deleted while being called because when deleted they\nalso destroy reference parameters values they are holding).\n\nBUG\u003d402993\n\nReview URL: https://codereview.chromium.org/551173004\n\nCr-Commit-Position: refs/heads/master@{#294474}\n", "tree_diff": [ { "type": "modify", "old_id": "189e58841c113cff22d04c8c7ef3fc99e9daa46b", "old_mode": 33188, "old_path": "remoting/protocol/BUILD.gn", "new_id": "4a7fa0e54fbe0e4500974a82765c1b85ce83ec02", "new_mode": 33188, "new_path": "remoting/protocol/BUILD.gn" }, { "type": "modify", "old_id": "3f1d9f6af1c4a3e7ab56d02e4c1ff5687b6c8d94", "old_mode": 33188, "old_path": "remoting/protocol/authenticator_test_base.cc", "new_id": "bd63cd733f93c209b0efa570a39b315dec8e563b", "new_mode": 33188, "new_path": "remoting/protocol/authenticator_test_base.cc" }, { "type": "modify", "old_id": "e20774ac90d7b5c0e5149e0cb160472c72c57ec2", "old_mode": 33188, "old_path": "remoting/protocol/authenticator_test_base.h", "new_id": "c5c7e6bca95949c5ef3edf528d97d9c6afc6d300", "new_mode": 33188, "new_path": "remoting/protocol/authenticator_test_base.h" }, { "type": "modify", "old_id": "7466b090716c7eb07c49defb0b48d31e7036acd1", "old_mode": 33188, "old_path": "remoting/protocol/channel_authenticator.h", "new_id": "8bef908df5cc810777fe2e2ec2239efd505681e0", "new_mode": 33188, "new_path": "remoting/protocol/channel_authenticator.h" }, { "type": "modify", "old_id": "10d64006c7e93164e674a4b841620af31a54f194", "old_mode": 33188, "old_path": "remoting/protocol/channel_dispatcher_base.cc", "new_id": "c292b2a154aff75281a6e4c87b41e4073df342a0", "new_mode": 33188, "new_path": "remoting/protocol/channel_dispatcher_base.cc" }, { "type": "modify", "old_id": "906d0f9bb2da1cc7e85512d80d5b949f03060622", "old_mode": 33188, "old_path": "remoting/protocol/channel_dispatcher_base.h", "new_id": "f71d291bb07ebc3b4ef03865f7f62cca2611113d", "new_mode": 33188, "new_path": "remoting/protocol/channel_dispatcher_base.h" }, { "type": "delete", "old_id": "31bf3ec9df205cd5ebcac5f13eaf183ff50ef8f4", "old_mode": 33188, "old_path": "remoting/protocol/channel_factory.h", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "modify", "old_id": "a6a80b4a694ab97e3ab4b7bf75e029f5f37633a1", "old_mode": 33188, "old_path": "remoting/protocol/channel_multiplexer.cc", "new_id": "5751440f2717f12270287571e7010fd3b6523383", "new_mode": 33188, "new_path": "remoting/protocol/channel_multiplexer.cc" }, { "type": "modify", "old_id": "924f132858d155bfbe41ad24ae73163ae0680f68", "old_mode": 33188, "old_path": "remoting/protocol/channel_multiplexer.h", "new_id": "506dc4b78af48af743a4676925832ff4a0325c83", "new_mode": 33188, "new_path": "remoting/protocol/channel_multiplexer.h" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "41ade7fe903c1848ae6d871f4e78a87c7c5ab273", "new_mode": 33188, "new_path": "remoting/protocol/datagram_channel_factory.h" }, { "type": "modify", "old_id": "bf06c56c6a8b61b0a7389d1424b46a793b4100d4", "old_mode": 33188, "old_path": "remoting/protocol/fake_authenticator.cc", "new_id": "9f2b4f6f08a2afa3982be5dfeb845fac8ad83559", "new_mode": 33188, "new_path": "remoting/protocol/fake_authenticator.cc" }, { "type": "modify", "old_id": "b74654d0426c63aedc718b4803e065a093282244", "old_mode": 33188, "old_path": "remoting/protocol/fake_authenticator.h", "new_id": "a6ddc74528ab07b2965dfc815e9d76a67b5fe63a", "new_mode": 33188, "new_path": "remoting/protocol/fake_authenticator.h" }, { "type": "modify", "old_id": "7c62ed2348512bad2e9793d8097ee4c5d4918c28", "old_mode": 33188, "old_path": "remoting/protocol/fake_session.cc", "new_id": "f02a47ade5757542d0ce572ad4c74aea22a4a00d", "new_mode": 33188, "new_path": "remoting/protocol/fake_session.cc" }, { "type": "modify", "old_id": "c7793f26f1e941578db39bf29b34c768be7e08f3", "old_mode": 33188, "old_path": "remoting/protocol/fake_session.h", "new_id": "524068168a028aca41fdf6997e412cd5f73404de", "new_mode": 33188, "new_path": "remoting/protocol/fake_session.h" }, { "type": "modify", "old_id": "727be4b073c2845f47c03f802154a9ee34b05ec6", "old_mode": 33188, "old_path": "remoting/protocol/jingle_session.cc", "new_id": "e6eb1e8a9b28da968d90ca2c9e435b9921669234", "new_mode": 33188, "new_path": "remoting/protocol/jingle_session.cc" }, { "type": "modify", "old_id": "dfb96cb462bbbe10896350b468a799420cb07c01", "old_mode": 33188, "old_path": "remoting/protocol/jingle_session.h", "new_id": "9ec62069fefc4040c10fba0d7691b5abe22b8a12", "new_mode": 33188, "new_path": "remoting/protocol/jingle_session.h" }, { "type": "modify", "old_id": "882e24dd6f22aa1f16740635bc5ad16c46b6d99d", "old_mode": 33188, "old_path": "remoting/protocol/jingle_session_unittest.cc", "new_id": "d7ce22896d4f9207a0bbcd28fa5f900196c8d9cf", "new_mode": 33188, "new_path": "remoting/protocol/jingle_session_unittest.cc" }, { "type": "modify", "old_id": "cc31440968ce51137640336f7ca4788493474ece", "old_mode": 33188, "old_path": "remoting/protocol/libjingle_transport_factory.cc", "new_id": "61ed3eafeba591bd021adca6412aff14a7b80db1", "new_mode": 33188, "new_path": "remoting/protocol/libjingle_transport_factory.cc" }, { "type": "modify", "old_id": "08661df6c4d3eadc8e8b3bfcc5f7992b53831211", "old_mode": 33188, "old_path": "remoting/protocol/libjingle_transport_factory.h", "new_id": "0b20ff7e98cd2055e962fef38cee1a9a5cc52d51", "new_mode": 33188, "new_path": "remoting/protocol/libjingle_transport_factory.h" }, { "type": "modify", "old_id": "7fc9eed500f408569326bbc3370d384f7991e3c3", "old_mode": 33188, "old_path": "remoting/protocol/protobuf_video_reader.cc", "new_id": "f566156b19d037df830af6f1adf1d19b0cc14a60", "new_mode": 33188, "new_path": "remoting/protocol/protobuf_video_reader.cc" }, { "type": "modify", "old_id": "f6bb55caa85dc46aa051359b48b5107ea364a3ba", "old_mode": 33188, "old_path": "remoting/protocol/protobuf_video_reader.h", "new_id": "ad0427379d608960ee8a80c4e5f4ebd61211729f", "new_mode": 33188, "new_path": "remoting/protocol/protobuf_video_reader.h" }, { "type": "modify", "old_id": "851d1ec28ae99945ad71113032b11f45992a8fd1", "old_mode": 33188, "old_path": "remoting/protocol/protobuf_video_writer.cc", "new_id": "81f2632c20cb44b831169e54ae15211bd7d2773e", "new_mode": 33188, "new_path": "remoting/protocol/protobuf_video_writer.cc" }, { "type": "modify", "old_id": "961e8219323416c99c45078e0c7e6a99714d8664", "old_mode": 33188, "old_path": "remoting/protocol/protobuf_video_writer.h", "new_id": "b139e150f7edc5dab58787c252767abc7c9e74a8", "new_mode": 33188, "new_path": "remoting/protocol/protobuf_video_writer.h" }, { "type": "modify", "old_id": "07e033064b1eefdafc7920bdf52ca4ba97967f78", "old_mode": 33188, "old_path": "remoting/protocol/protocol_mock_objects.h", "new_id": "281860482968f15ee47122ba03d0f7de2efee62e", "new_mode": 33188, "new_path": "remoting/protocol/protocol_mock_objects.h" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "689db92bde51b7fc45e81acb6fc24f26d5ef66f2", "new_mode": 33188, "new_path": "remoting/protocol/pseudotcp_channel_factory.cc" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "701b5d7c53fc8d4d0bbcc453a7ac508f0921895e", "new_mode": 33188, "new_path": "remoting/protocol/pseudotcp_channel_factory.h" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "df98378afc8fdb155371b275e5111e4928d21364", "new_mode": 33188, "new_path": "remoting/protocol/secure_channel_factory.cc" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "8f8e12e7000f0e0ec8208e3333ba64a73eed9225", "new_mode": 33188, "new_path": "remoting/protocol/secure_channel_factory.h" }, { "type": "modify", "old_id": "35b374076bd792dd307f038549e456bce1c1731e", "old_mode": 33188, "old_path": "remoting/protocol/session.h", "new_id": "f806e21dba8abac8086bd8db965f93db5e1cc9de", "new_mode": 33188, "new_path": "remoting/protocol/session.h" }, { "type": "modify", "old_id": "d85ad5f17ed99db39f6e5c9755e35fdf114bacd2", "old_mode": 33188, "old_path": "remoting/protocol/ssl_hmac_channel_authenticator.cc", "new_id": "f4bedeadf93039d696fe769d943683f9d12270df", "new_mode": 33188, "new_path": "remoting/protocol/ssl_hmac_channel_authenticator.cc" }, { "type": "modify", "old_id": "f4223c4e2f9a18adf81bfca3db6752d784bbced8", "old_mode": 33188, "old_path": "remoting/protocol/ssl_hmac_channel_authenticator.h", "new_id": "849dab310dc70b108c576fcfd03b94b26777ac82", "new_mode": 33188, "new_path": "remoting/protocol/ssl_hmac_channel_authenticator.h" }, { "type": "modify", "old_id": "cb239fbdc279dc041ae4f40732f9450250b2e1c5", "old_mode": 33188, "old_path": "remoting/protocol/ssl_hmac_channel_authenticator_unittest.cc", "new_id": "3b0818e17d3e76211e057374ffe2e0804f7c78d1", "new_mode": 33188, "new_path": "remoting/protocol/ssl_hmac_channel_authenticator_unittest.cc" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "6c3ebd1b97fb9265170c49d699011e7909187e24", "new_mode": 33188, "new_path": "remoting/protocol/stream_channel_factory.h" }, { "type": "modify", "old_id": "eb20e12a3c382c1a7218d566402595baaf24be10", "old_mode": 33188, "old_path": "remoting/protocol/transport.h", "new_id": "d4c4b3f8d8fa466017052c372e3764cf89c78fbc", "new_mode": 33188, "new_path": "remoting/protocol/transport.h" }, { "type": "modify", "old_id": "e9440ade3da813bf48672604372814cd6108764c", "old_mode": 33188, "old_path": "remoting/remoting_srcs.gypi", "new_id": "e8611d65d58d78dbfe87a71f621f9d399e9d9514", "new_mode": 33188, "new_path": "remoting/remoting_srcs.gypi" } ] }