Google Git
Sign in
chromium / chromium / src / 29032e48929471a747069454f3317e87a436405d
commit29032e48929471a747069454f3317e87a436405d[log] [tgz]
authorMinju Kim <mkim@igalia.com>Sat Jan 09 04:23:39 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Sat Jan 09 04:23:39 2021
tree5a10fd2da5850a3d591955b2e7dc27c47b9444de
parent0b548ee5e8324b84a0d7e5966023ab5124a11ff8 [diff]
Make rounded corner of browser frame from NonClientView::GetWindowMask

crrev.com/c/2578501 introduces
PlatformWindowDelegate::GetWindowMaskForWindowShape and updates
window region by the window mask in ozone/wayland.
This CL is the implementation to make the corner of the browser frame
rounded from the window mask.
It is done by XShape in x11, but there is no equivalent extension
of XShape in wayland.

In this CL,
1. Introduce WindowShapeUpdater to update |ui::Layer::alpha_shape_|
   for the rounded corner of window shape from
   NonClientView::GetWindowMask.
   - When bounds changes, ui::Layer::alpha_shape_ is updated according
     to the ShapeRects converted from NonClientView::GetWindowMask.
   - UpdateWindowTransparency when ui::Layer::alpha_shape_ is updated.

2. Set transparent:true to the compositor when NonClientView has
   window mask.
   Otherwise, AppendQuadsToFillScreen to always fill the entire
   screen in LayerTreeHostImpl.

Bug: 1126828
Change-Id: I3a712b8c5f33f9fd32bd2cd5e6ee8664732e3ca3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419056
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: MINJU KIM <mkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#841784}
6 files changed
tree: 5a10fd2da5850a3d591955b2e7dc27c47b9444de
  1. .clang-format
  2. .clang-tidy
  3. .eslintrc.js
  4. .git-blame-ignore-revs
  5. .gitattributes
  6. .gitignore
  7. .gn
  8. .vpython
  9. .vpython3
  10. .yapfignore
  11. AUTHORS
  12. BUILD.gn
  13. CODE_OF_CONDUCT.md
  14. DEPS
  15. DIR_METADATA
  16. ENG_REVIEW_OWNERS
  17. LICENSE
  18. LICENSE.chromium_os
  19. OWNERS
  20. PRESUBMIT.py
  21. PRESUBMIT_test.py
  22. PRESUBMIT_test_mocks.py
  23. README.md
  24. WATCHLISTS
  25. android_webview/
  26. apps/
  27. ash/
  28. base/
  29. build/
  30. build_overrides/
  31. buildtools/
  32. cc/
  33. chrome/
  34. chromecast/
  35. chromeos/
  36. cloud_print/
  37. codelabs/
  38. codereview.settings
  39. components/
  40. content/
  41. courgette/
  42. crypto/
  43. dbus/
  44. device/
  45. docs/
  46. extensions/
  47. fuchsia/
  48. gin/
  49. google_apis/
  50. google_update/
  51. gpu/
  52. headless/
  53. infra/
  54. ios/
  55. ipc/
  56. jingle/
  57. media/
  58. mojo/
  59. native_client_sdk/
  60. net/
  61. pdf/
  62. ppapi/
  63. printing/
  64. remoting/
  65. rlz/
  66. sandbox/
  67. services/
  68. skia/
  69. sql/
  70. storage/
  71. styleguide/
  72. testing/
  73. third_party/
  74. tools/
  75. ui/
  76. url/
  77. weblayer/
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.