commit | e303452bb7fd0208de51d623dc57d0afedbc9e57 | [log] [tgz] |
---|---|---|
author | John Delaney <johnidel@chromium.org> | Tue Mar 19 21:41:34 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Mar 19 21:41:34 2019 |
tree | 5cec9c964f46f626bf2def964717443df8f6cfdc | |
parent | f44d006014748c5baa2f8c29ce3da9c019f03da5 [diff] |
Key unfinished resources by GlobalRequestId in ads page load metrics Move the resource map to use GlobalRequestID instead of the blink request id to avoid any case of renderers having ongoing requests with conflicting id's. These resources are aggregated across renderers and blink request ids are only unique per-renderer. It is not expected this will have a noticeable difference in histograms. Request ids start at a random number in each renderer from 0->2^20, are then incremented by one for each request. We only care about collisions for two ongoing resource loads which is expected to be somewhat rare. Thus the associated Ads.ResourceUsage.* metrics and PageLoad.Clients.Ads.Bytes histograms will not be versioned. Bug: 943598 Change-Id: I9e599856a043d38d029cec6665e0a38776f2c3ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529661 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#642192}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .