tree ab9e749afc04788f3e09e1c31e32dd3df39a9cd7
parent a7e2e8634e1f21a26821573718bd67dd6b5a1e88
author Manu Cornet <manucornet@chromium.org> 1547896271 +0000
committer Commit Bot <commit-bot@chromium.org> 1547896271 +0000

CrOS shelf: Shelf bubble logic refactor

'Tis the season for refactorings :-)

* Rename ShelfTooltipBubbleBase into ShelfBubble
* Make ShelfBubble the base class for ShelfTooltipBubble,
  ShelfTooltipPreviewBubble, OverflowBubbleView.
* Refactor as much as possible of the common bubble creation logic.
* Remove OverflowBubbleView's custom 'InitOverflowBubble' method, just
  do that work in the constructor.
* Let the bubble take care of picking its own arrow (move that over
  from ShelfTooltipManager).

This change is not expected to have any user visible impact.

Change-Id: Icabddc9c23c5b22b9909813072a6eee8fa2d82cc
Reviewed-on: https://chromium-review.googlesource.com/c/1416799
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Auto-Submit: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624461}