commit | 2b542160832625cc47c6963b58c58416751d4d47 | [log] [tgz] |
---|---|---|
author | Julie Jeongeun Kim <jkim@igalia.com> | Thu Mar 07 03:21:41 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Mar 07 03:21:41 2024 |
tree | e069428fe14879705493fa20bc69ba5ac29691a7 | |
parent | 1ec9f27dc7cf0112165fdd716252ac285db0a85d [diff] |
Use InsertNodeBefore() on indenting a <blockquote> This CL replaces InsertNodeAfter() with InsertNodeBefore() on indenting a <blockquote>. InsertNodeAfter() has been used since [1]. When a eixsting <blockquote> has an image and a created <blockquote> for indenting is inserted after the existing node, the selection for deletion after cloning is canonicalized to non-range and DeleteSelection() does nothing. It causes there are two <blockquote>s with children, one is the existing <blockquote> supposed to be deleted and the other is the cloned <blockquote>. In order to fix the issue above, this change uses InsertNodeBefore() instead of InsertNodeAfter() to find the next node and the previous node for canonicalization without interference of the inserted <blockquote> and have the correct selection for deletion. [1] http://crbug.com/625802 Bug: 327665597 Change-Id: I3362a589ae5ac886fe301f605c2f0100807b3e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5334700 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/main@{#1269384}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.