commit | 2ba387a31dbdbf463d1c99b1e75cf52db0c587f2 | [log] [tgz] |
---|---|---|
author | Daniel Bratell <bratell@opera.com> | Wed Nov 07 19:17:27 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Nov 07 19:17:27 2018 |
tree | c820606df608c2cb0598da330dd82e9529a91307 | |
parent | da790f920bbc169a6805a4fb83b4c2ab09532d91 [diff] |
Remove using namespace from components/signin code The using namespace construct is disallowed in the code style guide. It also causes issues (compilation warnings turned into errors) in jumbo builds since they will be in a "header context" there which is explicitly blocked by our compiler settings. This patch also has a bit of a feature creep to remove a number of unnecessary static_casts that made the code hard to read, especially with the namespaces. Change-Id: Icaa4968695a6f033868aac681a9ebe08eee75c3e Reviewed-on: https://chromium-review.googlesource.com/c/1320131 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#606113}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .