commit 2e3a96d3b8a5c63ebd9b500967b7e9a2ff5a9420
author Florin Malita <fmalita@chromium.org> Wed Jul 11 17:27:29 2018
committer Commit Bot <commit-bot@chromium.org> Wed Jul 11 17:27:29 2018
tree 30d1c0782a0db9c169c9a11bf086d6e402fb02da
parent 17833dfe069a885e700d9bf9201aee17ff294868

Streamline WebCore -> SkBlendMode conversion helpers

Some of the conversion functions in skia_utils employ explicit look-up
tables.

Converting to switch statements yields

  1) less fragile code (no longer depending on Skia enum values/order)

  2) compile-time domain coverage check (-Wswitch), lets us drop the
     explicit checks + error logging.

  3) more readable code, aligned with the SkBlendMode -> WebCore
     conversion functions in the same CU.

  4) equivalent perf (modern compilers should turn these into look-up/jump
     tables).

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I527d47f6eb2f8e7372fb054aa7ac882f14fb69d0
Reviewed-on: https://chromium-review.googlesource.com/1132103
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574214}