commit a5ea255f5a86b495ed3caa6aa9590d0d03868d5b
author Mikel Astiz <mastiz@chromium.org> Mon Nov 06 22:50:15 2017
committer Commit Bot <commit-bot@chromium.org> Mon Nov 06 22:50:15 2017
tree 15c3e2c530c65d344aa17da656780730fc5364b7
parent 76d2fa68f1efb56557ea55d26e8556be12ecc079

Adopt enum class for favicon_base::IconType

Semi-automated patch composed almost entirely of renames, with the goal
to provide stronger type safety via enum class and most notably prevent
the enum from being used as bitmask (IconTypeSet should be used for
this).

The only non-trivial changes are in thumbnail_database.* where the enum
needs to be casted to/from int. We introduce helper functions and the
corresponding unit tests in preparation for future patches that will
modify the enum values.

Bug: 778551
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ide9a110a4d33ac5e94c6d113219631f24ef1ee1a
Reviewed-on: https://chromium-review.googlesource.com/753361
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514270}