tree 1d8acbc1ff29020a12e2d52b0f9b4eb155b3cec0
parent db5594b59c5f6a1384931764d03c87039ba6a570
author Rushan Suleymanov <rushans@google.com> 1679921632 +0000
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1679921632 +0000

[Sync] Handle server response parsing failures

If the server returns a response which is unparsable, return a
SERVER_RESPONSE_VALIDATION_FAILED error. Prior to this CL, UNSET
SyncerError was used.

PostAndProcessHeaders can return false even if the server status is
SERVER_CONNECTION_OK. This CL fixes corresponding DCHECKs to handle this
case.

Bug: 1423601
Change-Id: Ieb111ac7d11c30dae556209eb3160d280bfc870f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4372843
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Rushan Suleymanov <rushans@google.com>
Cr-Commit-Position: refs/heads/main@{#1122358}