commit | 332dadb68e5b4531d80ada8c0143f69010ccbbab | [log] [tgz] |
---|---|---|
author | Michael Thiessen <mthiesse@chromium.org> | Wed Jul 13 14:44:07 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Jul 13 14:44:07 2022 |
tree | 22a0eb3f4c8e4590ca430f37bff6ec70012cd159 | |
parent | 64a159eee72c6d5bddd6a467c9391f9ddc120f57 [diff] |
Introduce 15s timeout for navigation chains launching apps Websites should not be given indefinitely long to redirect to an app, as we don't want an unattended page to launch an app. This change unifies the xhr-initiated and non-xhr-initiated navigation chains to timeout after 15 seconds from when the user initiated the navigation (or xhr). (Technically if the site waits until the user activation in blink is about to expire before kicking off the navigation then up to 20 seconds can be taken.) If the navigation chain is expired and no fallback URL is provided, a Message is shown to the user asking if they would like to launch the app. Future changes would ideally replace the UserGestureCarryover IPC with the time the user activation took place and set a bit on the NavigationHandle for navigations that happened during a resource request callback in javascript. However, there's no urgent need to make such changes. Doc: https://docs.google.com/document/d/1NVk_3eNRJ3aTXePTKk-9tC36LtNVvMUFoSeIc9cBi48/edit# Bug: 1311399 Change-Id: I40b13dc37195d1f9ccda9bf304a4c1483edbf695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3746265 Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Bo Liu <boliu@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/main@{#1023725}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.