commit | 334d6874841ce5e0f15b7019241ed648c8b3b172 | [log] [tgz] |
---|---|---|
author | Daniel Bratell <bratell@opera.com> | Fri Mar 08 21:17:47 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Mar 08 21:17:47 2019 |
tree | 0e4fe41c737a74b673c931c2e59208a19a9d2518 | |
parent | 0b555eb775650a66006d38d78ad48063966415da [diff] |
Add necessary explicit deps for extension apis Several missing build dependencies were revealed by an updated gn check, including a number related to the extension api registration where code used headers from browser and browser/extensions. Since they cannot depend directly on those (would create dependency cycles) allow_circular_includes must be used instead. Example problems: ERROR at //out/Default/gen/chrome/browser/apps/platform_apps/api/generated_api_registration.cc:8:11: Can't include this header from here. #include "chrome/browser/apps/platform_apps/api/music_manager_private/music_manager_private_api.h" ERROR at //out/Default/gen/chrome/browser/extensions/api/generated_api_registration.cc:7:11: Include not allowed. #include "chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h" ERROR at //out/Default/gen/chrome/browser/extensions/api/generated_api_registration.cc:66:11: Include not allowed. #include "chrome/browser/accessibility/accessibility_extension_api.h" Change-Id: I432d44da18b236bf51f9736f58e990dd42a82a15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505449 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Auto-Submit: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#639168}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .