commit | 3473fc9470bccb35aa0dc6a561c2421e2e88f7e0 | [log] [tgz] |
---|---|---|
author | Daniel Bratell <bratell@opera.com> | Wed Apr 03 17:22:02 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Apr 03 17:22:02 2019 |
tree | bf3e89957e7419ac62e891372d6630aaa6635dbf | |
parent | 6827be33eeb67ed720eff37f7386c0bf81c6e93a [diff] |
Fix deps for some mojo tests gn check --check-generated revealed a hidden dependency not expressed in the build scripts which is fixed by this. The exact error was like the one below (and a couple like it): ERROR at //out/Default/gen/mojo/public/interfaces/bindings/tests/test_import.mojom-blink-test-utils.cc:23:11: Can't include this header from here. ^-------------------------------------------------------------- The target: //mojo/public/interfaces/bindings/tests:test_exported_import_blink is including a file from the target: //mojo/public/interfaces/bindings/tests:test_export_blink__generator It's usually best to depend directly on the destination target. In some cases, the destination target is considered a subcomponent of an intermediate target. In this case, the intermediate target should depend publicly on the destination to forward the ability to include headers. Dependency chain (there may also be others): //mojo/public/interfaces/bindings/tests:test_exported_import_blink --> //mojo/public/interfaces/bindings/tests:test_export_blink_component --[private]--> //mojo/public/interfaces/bindings/tests:test_export_blink --> //mojo/public/interfaces/bindings/tests:test_export_blink__generator Bug: 938893 Change-Id: Id7d4be31ef01e37054c381a7fce7eca43ac1b753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545914 Auto-Submit: Daniel Bratell <bratell@opera.com> Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#647342}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .