commit | 34bfc576d6c97ee2f6e7a45f58f9bfd68cc0e36a | [log] [tgz] |
---|---|---|
author | Maksim Sisov <msisov@igalia.com> | Tue Jan 14 07:03:12 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Jan 14 07:03:12 2025 |
tree | b490c47336d20778539e9a3506fcca071c478dbf | |
parent | f71937225b6aa47f7780e5391a4584d1a8b74318 [diff] |
Clarify PRESUBMIT message for Lacros deprecation The Lacros platform is deprecated, and its associated code is being removed. Previously, the PRESUBMIT script was updated to recommend transitioning to the IS_CHROMEOS build flag However, this change introduced ambiguity, leading to the misinterpretation that IS_CHROMEOS_LACROS should be renamed to IS_CHROMEOS alongside the IS_CHROMEOS_ASH build flag. This CL refines the PRESUBMIT message to clearly state: 1) Code under IS_CHROMEOS_LACROS must be removed. 2) The IS_CHROMEOS_ASH build flag should be renamed to IS_CHROMEOS. This update aims to eliminate confusion and provide precise guidance during the deprecation process. Bug: 388039763 Change-Id: I0cdd7a788da220ecca17f021a1597d2c41b2c05f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6169131 Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Rick Byers <rbyers@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1405919}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.