[signin] Pass ProfileAttributesStorage in SigninProfileAttributesUpdater constructor

g_brower_process()->profile_manager() returns null during profile
destruction, even though the profile manager has not been destroyed yet.

Instead of retrieving the ProfileAttributesStorage from g_browser_process,
this CL passes it in the constructor.

Note that, although ProfileAttributesStorage supports weak pointers, it
is actually not necessary to use them here, because the storage outlives
the SigninProfileAttributesUpdater anyway.

As a side effect, the AccountConsistencyModeManager is no longer always
created at the profile creation (because SigninProfileAttributesUpdater
now sometimes early-returns before creating it).
This CL changes AccountConsistencyModeManagerFactory to always instantiate
the service.

Bug: 953596
Change-Id: Ib8bfaf8eed1fbf8b121e28737b0c665e19f818a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578739
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654019}
6 files changed