commit | 35a5292481c4932de395906242f491f46baed743 | [log] [tgz] |
---|---|---|
author | Yuichiro Hanada <yhanada@chromium.org> | Wed Apr 11 12:04:57 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Apr 11 12:04:57 2018 |
tree | 8443810e9902127aaa33bacdd210dbd6d9013abd | |
parent | 58a1a76874d1f16fe9eea8eaa642cf5a28c48543 [diff] |
Revert "Floating Keyboard stops propagation of drag handle events" This reverts commit 6b3d6841cf0897f2824c799098d6c24eaa0ac679. Reason for revert: Please refer to crbug.com/831521 . We need to pass tap events in the drag handle. Original change's description: > Floating Keyboard stops propagation of drag handle events > > If a touch/mouse event occurs and it is interpreted as a floating > keyboard drag event, do not propagate the event to the javascript > keyboard extension as there is no reason to. > > This was causing the drag event to cause the gesture swiping to be > active while dragging the keyboard around, particularly if the keyboard > was bounded to the bottom of the screen and the user's finger is able > to move around on the keys while still moving the keyboard (see > attached bug for repro/video). > > Bug: 826078 > Change-Id: I40c859f979d41a5d61e88ff0bd41808dcf3940c2 > Reviewed-on: https://chromium-review.googlesource.com/997195 > Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> > Commit-Queue: Blake O'Hare <blakeo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#548374} TBR=yhanada@chromium.org,blakeo@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 826078 Bug: 831521 Change-Id: I9dded92a6e7b2ec1f97ebd169c463686c23d5d7c Reviewed-on: https://chromium-review.googlesource.com/1006715 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#549862}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .