commit | 363d5ef64599940fdf87a4f1cc0775590c427c8d | [log] [tgz] |
---|---|---|
author | Ehsan Chiniforooshan <chiniforooshan@chromium.org> | Tue Mar 19 15:05:28 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Mar 19 15:05:28 2019 |
tree | ca3a057a683c0eee00b2a54bc34cfbaa73eb9697 | |
parent | 2d03b5b49af582ba9eb639653651be451974e1d4 [diff] |
Telemetry: step 1 of removing redundant metrics There are some code in renderingMetric for computing metrics that are available as an UMA metric, too. Now that we can use UMA histograms in Telemetry (crbug.com/927067), there is no need to have two implementations for those metrics (one in the chromium repo and one in the catapult repo), that can potentially get out of sync. So, 1. This CL adds Event.Latency.ScrollUpdate.Touch.TimeToScrollUpdateSwapBegin4 and Event.Latency.ScrollBegin.Touch.TimeToScrollUpdateSwapBegin4 to benchmarks that use renderingMetric. 2. Next, we will change perf dashboard alert configurations to use the above-mentioned UMA metrics instead of input_event_latency and first_gesture_scroll_update_latency. 3. We will delete the catapult code for computing input_event_latency and first_gesture_scroll_update_latency (crrev.com/c/1526202). To see that the UMA versions and the Catapult versions have very similar values you can check the rendering.{desktop, mobile} benchmarks that have had both versions for a while now. E.g: https://v2spa-dot-chromeperf.appspot.com/#session=95f926ce50a834326541dfee68bcc5b0ec04fbf12a1b9b77794ece90a63a20bb BUG=943559 Change-Id: Ia47ac69e97748cc17eebb648336b2d54733f2ce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526165 Reviewed-by: Annie Sullivan <sullivan@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Ravi Mistry <rmistry@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Reviewed-by: Eric Karl <ericrk@chromium.org> Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Cr-Commit-Position: refs/heads/master@{#641872}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .