Google Git
Sign in
chromium / chromium / src / 364558ac95b388e2e51be4fa56ab91cfe556ab0e
commit364558ac95b388e2e51be4fa56ab91cfe556ab0e[log] [tgz]
authorCJ DiMeglio <lethalantidote@chromium.org>Tue Jan 15 03:20:53 2019
committerCommit Bot <commit-bot@chromium.org>Tue Jan 15 03:20:53 2019
tree112cfbcec874a3746fb4ef30260c1cd5040b3a83
parente046b872aa1757eb3a9cb9a31a8b5c0e79cff729 [diff]
Updates captions menu to use aria attributes.

This CL adds aria attributes to the closed captions menu. Previously there was very little
screenreader functionality for this menu. Now users will be able to know what menu they
are in, which button closes the menu, and be able to select each option while obtaining
relative positioning information for each.

Bug: 836549
Change-Id: Ib8177d9d1d1f559939333a246aff23a345c110eb
Reviewed-on: https://chromium-review.googlesource.com/c/1379178
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622708}
8 files changed
tree: 112cfbcec874a3746fb4ef30260c1cd5040b3a83
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .