Google Git
Sign in
chromium / chromium / src / 3669e7b2a53c0dfca0db40466dfacece509b2059
commit3669e7b2a53c0dfca0db40466dfacece509b2059[log] [tgz]
authorRayan Kanso <rayankans@chromium.org>Wed Feb 06 13:58:06 2019
committerCommit Bot <commit-bot@chromium.org>Wed Feb 06 13:58:06 2019
tree9e5f50a700557849b4312a5f9a39e67c05c51728
parent6aa9866c32492bd76948ed78e97db5768bc2d521 [diff]
[Background fetch] Forward-fix test regression.

In the delegate proxy refactor (crrev.com/1422158), some if statements
where changed to DCHECKs. When aborted, some of the Download Service
callbacks can still be received due to race conditions.

This CL switches the DCHECKs back to if statements.

Bug: 850512
Change-Id: I4154070635d5434819c07b394fbfe323ca9fdb9e
Reviewed-on: https://chromium-review.googlesource.com/c/1456063
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629554}
1 file changed
tree: 9e5f50a700557849b4312a5f9a39e67c05c51728
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. mash/
  33. media/
  34. mojo/
  35. native_client_sdk/
  36. net/
  37. pdf/
  38. ppapi/
  39. printing/
  40. remoting/
  41. rlz/
  42. sandbox/
  43. services/
  44. skia/
  45. sql/
  46. storage/
  47. styleguide/
  48. testing/
  49. third_party/
  50. tools/
  51. ui/
  52. url/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .