commit | 399eed41d62b91b9d28b3447d870cca523b2b24d | [log] [tgz] |
---|---|---|
author | Karan Bhatia <karandeepb@chromium.org> | Mon Mar 05 23:30:44 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Mar 05 23:30:44 2018 |
tree | 397b89fd74854f72026a49a2671113f5f9328462 | |
parent | d7d70a866ad600f707ce27a7132b9e99c803bcd7 [diff] |
Extensions: Ensure Devtools frames are correctly tracked by ExtensionWebContentsObserver. Currently ExtensionWebContentsObserver(EWCO) does not get RenderFrameCreated notification for the Devtools main frame. This happens because the frame is created before the EWCO construction. Also, at the time of ExtensionWebContentsObserver construction, this frame happens to be the speculative RenderFrameHost of the root FrameTreeNode and hence is not enumerated via WebContents::ForEachFrame. To fix this, also track the new hosts seen through the WebContentsObserver::RenderFrameHostChanged method. Add a browser test for the same. Also, rename ExtensionAPIFrameIdMap::OnRenderFrameCreated to InitializeRenderFrameHost to clarify the new usage. BUG=817075 Change-Id: I81213f0441162a483fda9191991763a3fee65905 Reviewed-on: https://chromium-review.googlesource.com/942684 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#540978}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .