Google Git
Sign in
chromium / chromium / src / 39abd3ff5d3933cdb0f75f4fa1598649721af9e5
commit39abd3ff5d3933cdb0f75f4fa1598649721af9e5[log] [tgz]
authorDave Tapuska <dtapuska@chromium.org>Wed Sep 11 22:17:22 2019
committerCommit Bot <commit-bot@chromium.org>Wed Sep 11 22:17:22 2019
tree2266258e5695f0739b17a4bb0e1e5ba70cc90955
parent6a144ecb5d0da10ef29442d141bc0a9fb90feb81 [diff]
Fix crash in PauseContext/UnpauseContext.

It is possible that the frame becomes detached from the document
after dispatching the event. This is the only way the FrameScheduler
could be null. I previously checked it in SetLifecycleState in
change https://chromium.googlesource.com/chromium/src.git/+/42b61856cfd1b63bed1a1cae45cac6b7e41e9e0f
and that seemed to decrease the number of crashes, but they still
seem to exist. These additional checks should cover those situations.

BUG=994442

Change-Id: I59ad0e4f4e047f4548c72ad103691a260290626e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798888
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695813}
1 file changed
tree: 2266258e5695f0739b17a4bb0e1e5ba70cc90955
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. .vpython3
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .